search

neo4j / neo4j-browser

Neo4j Browser is the general purpose user interface for working with Neo4j. Query, visualize, administrate and monitor the database.
https://neo4j.com
GNU General Public License v3.0
671 stars 345 forks source link

Inconsistent "Element ID" property name #1955

Open QubitPi opened 8 months ago

QubitPi commented 8 months ago

Description

The "Element ID" in Default Details Pane has a different naming with the rest of the code base.

It's elementId everywhere, such as Details Pane, except for the one above. Does element-id happen to be a typo?

Thanks

OskarDamkjaer commented 8 months ago

Hi @QubitPi! It would indeed make more sense to call it elementId there as well. We're planning to get rid of the DefaultDetailsPane as we no longer use the arc package, so it doesn't really matter to us, but it's an easy fix so feel free to change it if you like!

QubitPi commented 8 months ago

Hi @OskarDamkjaer, thank you for your response. That makes sense.

Actually, our team is using neo4j-arc library and DefaultDetailsPane in our application, because it was an easy pickup so we don't have to implement and maintain our own DetailsPane. Currently we are using element-id only in our tests

Since upstream is deciding to deprecate the default one, I think we can simply live with that. We can handle this special case :)

Thanks.

OskarDamkjaer commented 8 months ago

Oh cool! The last release of the neo4j-arc package was nine months ago, so if you'd install that you'd not get this change regardless right? How do you depend on the arc package?

QubitPi commented 8 months ago

We actually forked neo4j-browser's master branch, made some modifications, and use the fork in our application instead. We also regularly rebase our fork on top of upstream master which is why we could also see the very recent changes such as element ID in our fork

It's important because not only did we use element-id in tests, but we also added some new features to it such as double-clicking the canvas will create a new node. We are happy to contribute some of them back to updstream if our dearest Neo4J team found them useful as well :)