search

neo4j / neo4j-dotnet-driver

Neo4j Bolt driver for .NET
Apache License 2.0
226 stars 69 forks source link

Implement pipelined begin for executable query #724

Closed thelonelyvulpes closed 1 year ago

thelonelyvulpes commented 1 year ago

Optimizes running executable queries by removing a server round trip.

thelonelyvulpes commented 1 year ago

Awaiting: https://github.com/neo4j-drivers/testkit/pull/588

thelonelyvulpes commented 1 year ago

Looks good, pretty straightforward. Again we find ourselves passing parameters down the stack. Was going to question the switch to using Session instead of AsyncSession, then realised it is just a wrapper method for Session.

I have moved the parameter into an object, going forward we can push values on to that instead of adding a parameter to several methods. There's still a couple more bolt protocol methods that could do with a parameter object treatment but I think tackling them one by one keeps the size of changes down.