fbiville
commented
1 year ago @timrulebosch thanks for the report! I have not been to reproduce the issue just yet. What server version are you running?
Here are the steps I followed:
docker run --rm \
--env NEO4J_AUTH='neo4j/letmein!' \
--env NEO4J_ACCEPT_LICENSE_AGREEMENT=yes \
--publish=7687:7687 \
--health-cmd "cypher-shell -u neo4j -p 'letmein!' 'RETURN 1'" \
--health-interval 5s \
--health-timeout 5s \
--health-retries 5 \
neo4j:4.4-enterpriseAnd I ran the following program (with an invalid label):
package main
import (
"context"
"fmt"
"github.com/neo4j/neo4j-go-driver/v5/neo4j"
"strings"
)
func main() {
ctx := context.Background()
driver, err := neo4j.NewDriverWithContext("neo4j://localhost", neo4j.BasicAuth("neo4j", "letmein!", ""))
if err != nil {
panic(err)
}
defer dealWithIt(ctx, driver)
session := driver.NewSession(ctx, neo4j.SessionConfig{})
defer dealWithIt(ctx, session)
for i := 0; i < 5; i++ {
fmt.Printf("Call #%d\n", i+1)
summary, err := session.ExecuteWrite(ctx, addNodeFunc(ctx, []string{"F o o", "Bar"}, "Jane Doe"))
if err != nil {
panic(err)
}
fmt.Printf("Node(s) created: %d\n", summary.(neo4j.ResultSummary).Counters().NodesCreated())
}
}
func addNodeFunc(ctx context.Context, labels []string, name string) neo4j.ManagedTransactionWork {
return func(tx neo4j.ManagedTransaction) (any, error) {
var b strings.Builder
b.WriteString("CREATE (n:" + strings.Join(labels, ":") + " {name: $name}) ")
b.WriteString("RETURN id(n) ")
query := b.String()
result, err := tx.Run(ctx, query, map[string]any{"name": name})
if err != nil {
return nil, err
}
return result.Consume(ctx)
}
}
func dealWithIt(ctx context.Context, closer interface{ Close(context.Context) error }) {
if err := closer.Close(ctx); err != nil {
panic(err)
}
}
which gives me:
Call #1
panic: Neo4jError: Neo.ClientError.Statement.SyntaxError (Invalid input 'o': expected ")", "WHERE", "{" or a parameter (line 1, column 13 (offset: 12))
"CREATE (n:F o o:Bar {name: $name}) RETURN id(n)"
^)
goroutine 1 [running]:
main.main()Would you be able to update the program and make it crash as in the initial report? Thanks a lot!
timrulebosch
The resetResponseHandler does not set an onIgnored callback. If that handler is called for a bolt message of type "ignored" then you get a SIGSEV as follows:
The callback is thus (see
onIgnored: nil):Adding
onIgnored: onIgnoredNoOp,to the resetResponseHandler() would likely fix the fault.https://github.com/neo4j/neo4j-go-driver/blob/0eccfa3db544f6639151bf013cb08a3dde97fc70/neo4j/internal/bolt/bolt4.go#LL1078C1-L1091C2
The scenario behind this is fairly simple (and probably stupid) ... however, I'm new to Go ... based of the example, I basically run this function twice with the same parameters, the second time fails.