Enhance Neo4j integration test configuration For Feature Request #428

neo4j / neo4j-go-driver

Neo4j Bolt Driver for Go

Apache License 2.0

490 stars 69 forks source link

Enhance Neo4j integration test configuration For Feature Request #428 #544

Closed lucapirolo closed 11 months ago

lucapirolo commented 11 months ago

Add getVersionFromDB to DbServer for dynamic version detection
Remove default version in VersionOf if empty
Default GetDbServer to localhost when TEST_NEO4J_HOST unset
https://github.com/neo4j/neo4j-go-driver/issues/428

StephenCathcart commented 11 months ago

Hi @lucapirolo

Thank you for taking the time to contribute to a Neo4j project, we appreciate all community engagement. Before we review a change we require that users have signed our Contributor License Agreement(CLA). This allows the "whitelist-check (pull-request)" part of our build process to pass. For more details on signing our CLA please see: https://neo4j.com/developer/cla/. Specifically the 'How to Sign' section.

Apologies for any inconvenience!

lucapirolo commented 11 months ago

Hi @StephenCathcart, I've completed and signed the CLA agreement. Could you please rerun the pipeline? Assuming my CLA submission has been accepted, it should now pass the whitelist check. Thank you!

StephenCathcart commented 11 months ago

Hi @StephenCathcart, I've completed and signed the CLA agreement. Could you please rerun the pipeline? Assuming my CLA submission has been accepted, it should now pass the whitelist check. Thank you!

Hi @lucapirolo, I can confirm we received the agreement and I've updated the whitelist database. I'll rerun the pipeline in a moment 👍.