neo4j / neo4j-javascript-driver

Neo4j Bolt driver for JavaScript
https://neo4j.com/docs/javascript-manual/current/
Apache License 2.0
839 stars 148 forks source link

Improve AuthProvider performance #1172

Open bigmontz opened 5 months ago

bigmontz commented 5 months ago

This method was doing expensive object comparison for objects when connection auth token is null. This causes a performance penalty on the driver.

vongruenigen commented 5 months ago

@bigmontz is there some kind of policy who and what can be reviewed by non-neo4j engineers? If it allows for I could very well imagine starting to tinker more with the driver and maybe assist you with some reviews for smaller MRs (such as this one), if my time permits.

PS: Sorry if this is kinda off-topic regarding this MR, wasn't really sure where to post this.