neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 276 forks source link

big decimal converter fix #1507

Closed klobuczek closed 6 years ago

klobuczek commented 6 years ago

Fixes # Extract the BigDecimalConverter only against 9.2.x This pull introduces/changes:

codecov-io commented 6 years ago

Codecov Report

Merging #1507 into 9.2.x will decrease coverage by 25.4%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            9.2.x    #1507       +/-   ##
===========================================
- Coverage   96.83%   71.42%   -25.41%     
===========================================
  Files         205        1      -204     
  Lines       12675        7    -12668     
===========================================
- Hits        12274        5    -12269     
+ Misses        401        2      -399
Impacted Files Coverage Δ
lib/neo4j/core/query.rb 71.42% <0%> (-28.58%) :arrow_down:
...ctional_migrations/1231231231_failing_migration.rb
spec/integration/label_spec.rb
lib/neo4j/active_node/reflection.rb
lib/neo4j/active_node/validations.rb
lib/neo4j/type_converters.rb
lib/rails/generators/neo4j_generator.rb
spec/unit/shared/typecasted_attributes_spec.rb
spec/e2e/has_one_spec.rb
lib/neo4j/shared/rel_type_converters.rb
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65f9612...feb6524. Read the comment docs.

cheerfulstoic commented 6 years ago

Oy, and of course it's trying to run against master. I'll merge it in and then change the .travis.yml to run against the right branch of neo4j-core and then revert that in master

cheerfulstoic commented 6 years ago

Released as 9.2.4