neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 276 forks source link

Adding companion instance method with scope #1512

Closed amitsuryavanshi closed 6 years ago

amitsuryavanshi commented 6 years ago

Fixes #

This pull introduces/changes:

codecov-io commented 6 years ago

Codecov Report

Merging #1512 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
+ Coverage   96.82%   96.82%   +<.01%     
==========================================
  Files         205      205              
  Lines       12682    12688       +6     
==========================================
+ Hits        12279    12285       +6     
  Misses        403      403
Impacted Files Coverage Δ
spec/e2e/scope_spec.rb 100% <100%> (ø) :arrow_up:
lib/neo4j/active_node/scope.rb 94.11% <100%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10066fe...a0a51d2. Read the comment docs.

jorroll commented 6 years ago

This will also address #1461 (and, as concluded in that PR, this is a better solution)

amitsuryavanshi commented 6 years ago

Ahh I missed that PR @thefliik, Let me know if you want incorporate this change in your PR, I can close this.

jorroll commented 6 years ago

No, the conclusion reached in #1461 was that this is a better solution to the problem. No one had gotten around to adding it though. So thanks! 👍

cheerfulstoic commented 6 years ago

This is fabulous, thanks!

cheerfulstoic commented 6 years ago

Released as 9.3.0