neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 276 forks source link

Query proxy where or #1533

Closed amitsuryavanshi closed 5 years ago

amitsuryavanshi commented 5 years ago

Fixes #

This pull introduces/changes:

codecov-io commented 5 years ago

Codecov Report

Merging #1533 into master will increase coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1533      +/-   ##
==========================================
+ Coverage   93.24%   93.42%   +0.18%     
==========================================
  Files         104      104              
  Lines        4724     4611     -113     
==========================================
- Hits         4405     4308      -97     
+ Misses        319      303      -16
Impacted Files Coverage Δ
lib/neo4j/active_node/query/query_proxy_link.rb 100% <100%> (ø) :arrow_up:
lib/neo4j/active_node/query/query_proxy.rb 94.93% <100%> (+0.52%) :arrow_up:
lib/neo4j/migrations/schema_migration.rb 88.88% <0%> (-11.12%) :arrow_down:
lib/neo4j/session_manager.rb 84.78% <0%> (-10.87%) :arrow_down:
lib/neo4j/shared/initialize.rb 92.3% <0%> (-7.7%) :arrow_down:
lib/neo4j/railtie.rb 80% <0%> (-0.73%) :arrow_down:
lib/rails/generators/neo4j_generator.rb 65.45% <0%> (-0.62%) :arrow_down:
lib/neo4j/active_node/property.rb 93.93% <0%> (-0.51%) :arrow_down:
lib/neo4j/migration.rb 81.39% <0%> (-0.43%) :arrow_down:
lib/neo4j/active_node/labels.rb 92.78% <0%> (-0.29%) :arrow_down:
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d02143...9e36e4d. Read the comment docs.

klobuczek commented 5 years ago

@amitsuryavanshi could you add documentation and changelog

amitsuryavanshi commented 5 years ago

Closing this PR as this does not sound like a viable option.