neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 276 forks source link

Require Forwardable module #1541

Closed jschulenklopper closed 5 years ago

jschulenklopper commented 5 years ago

Not sure whether this is the most proper fix (and fix location), but the Forwardable module is missing from the require statements. That results in an error

/usr/local/lib/ruby/gems/2.5.0/gems/neo4j-9.4.0/lib/neo4j/shared/property.rb:119:in `': uninitialized constant Neo4j::Shared::Property::ClassMethods::Forwardable (NameError)

when including a Neo4j module, as reported in #1535.

Fixes #1535

codecov-io commented 5 years ago

Codecov Report

Merging #1541 into master will increase coverage by 0.16%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1541      +/-   ##
=========================================
+ Coverage   93.24%   93.4%   +0.16%     
=========================================
  Files         104     104              
  Lines        4724    4810      +86     
=========================================
+ Hits         4405    4493      +88     
+ Misses        319     317       -2
Impacted Files Coverage Δ
lib/neo4j.rb 97.95% <100%> (+0.02%) :arrow_up:
lib/neo4j/migrations/schema_migration.rb 88.88% <0%> (-11.12%) :arrow_down:
lib/neo4j/active_base.rb 88.88% <0%> (-2.03%) :arrow_down:
lib/neo4j/active_node.rb 95% <0%> (-1.56%) :arrow_down:
...ib/rails/generators/neo4j/model/model_generator.rb 60% <0%> (-1.37%) :arrow_down:
lib/neo4j/shared/type_converters.rb 94.71% <0%> (-1.24%) :arrow_down:
lib/neo4j/active_node/has_n.rb 98.4% <0%> (-0.37%) :arrow_down:
...o4j/active_node/query/query_proxy_eager_loading.rb 100% <0%> (ø) :arrow_up:
...4j/active_node/has_n/association_cypher_methods.rb 100% <0%> (ø) :arrow_up:
lib/neo4j/class_arguments.rb 90% <0%> (ø) :arrow_up:
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d02143...d055ff6. Read the comment docs.