neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 276 forks source link

Fix remove_property #1559

Closed lshimokawa closed 5 years ago

lshimokawa commented 5 years ago

Fixes # When using remove_property as mentioned in the docs:

remove_property(:User, :session_context)

It generates this Cypher, which doesn't work to remove the property

 CYPHER
  MATCH (n:`User`)
  REMOVE n:`session_context`

This pull introduces/changes:

 CYPHER
  MATCH (n:`User`)
  REMOVE n.`session_context`
codecov-io commented 5 years ago

Codecov Report

Merging #1559 into master will increase coverage by 0.16%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
+ Coverage   93.23%   93.39%   +0.16%     
==========================================
  Files         105      105              
  Lines        4758     4954     +196     
==========================================
+ Hits         4436     4627     +191     
- Misses        322      327       +5
Impacted Files Coverage Δ
lib/neo4j/migrations/helpers.rb 100% <100%> (ø) :arrow_up:
lib/neo4j/shared/initialize.rb 89.47% <0%> (-10.53%) :arrow_down:
lib/neo4j/shared/property.rb 97.77% <0%> (+0.19%) :arrow_up:
lib/neo4j/active_node/has_n.rb 99.4% <0%> (+0.21%) :arrow_up:
lib/neo4j/shared/persistence.rb 96.17% <0%> (+0.23%) :arrow_up:
lib/neo4j/active_rel/persistence.rb 96.8% <0%> (+1.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e67abc2...b0d941d. Read the comment docs.