search

neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 276 forks source link

fixed most of rubocop issues #1591

Closed mrhardikjoshi closed 2 years ago

mrhardikjoshi commented 4 years ago

Fixes most of the rubocop issues and updates the rubocop yml configuration file to use ruby 2.5

codecov-io commented 4 years ago

Codecov Report

Merging #1591 into 10.0.x will not change coverage. The diff coverage is 82.69%.

Impacted file tree graph

@@           Coverage Diff           @@
##           10.0.x    #1591   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         125      125           
  Lines        5865     5865           
=======================================
  Hits         5493     5493           
  Misses        372      372
Impacted Files Coverage Δ
lib/neo4j/core/label.rb 77.33% <0%> (ø) :arrow_up:
lib/neo4j/active_node/query/query_proxy_link.rb 100% <100%> (ø) :arrow_up:
lib/neo4j/shared/initialize.rb 100% <100%> (ø) :arrow_up:
...node/query/query_proxy_methods_of_mass_updating.rb 100% <100%> (ø) :arrow_up:
lib/neo4j/shared.rb 86.66% <100%> (ø) :arrow_up:
lib/neo4j/active_rel/query.rb 95.91% <100%> (ø) :arrow_up:
lib/neo4j/active_node/has_n.rb 99.23% <100%> (ø) :arrow_up:
lib/neo4j/shared/persistence.rb 96% <100%> (ø) :arrow_up:
lib/neo4j/core/query_builder.rb 93.33% <100%> (ø) :arrow_up:
lib/neo4j/shared/callbacks.rb 100% <100%> (ø) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f03e7c7...00f897b. Read the comment docs.

mrhardikjoshi commented 2 years ago

closing this as it is no longer salvageable.