search

neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 276 forks source link

Fix for with_associations eager loading issue with relationship on same model #1598

Closed amitsuryavanshi closed 4 years ago

amitsuryavanshi commented 4 years ago

In a case where association is on the same model where it is defined and we eagerload such relationship with with_associations, we are getting extra queries fired rather than one.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit f0d2e970 and detected 0 issues on this pull request.

View more on Code Climate.

codecov-io commented 4 years ago

Codecov Report

Merging #1598 into master will not change coverage by %. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1598   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         126      126           
  Lines        5735     5735           
=======================================
  Hits         5386     5386           
  Misses        349      349
Impacted Files Coverage Δ
...tive_graph/node/query/query_proxy_eager_loading.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ed9824...f0d2e97. Read the comment docs.