joshjordan commented 3 years ago

This appears to be unused. We had some code that handled ConnectionFailedError in neoj4rb 9, and that code was throwing uninitialized constant ActiveGraph::Core::ConnectionFailedError. While ActiveGraph::Core::ConnectionFailedError was actually written, it was never loaded and the code makes no reference to it.

I expect the test suite to prove out that this file has no effect on the codebase.

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 993f2c81 and detected 0 issues on this pull request.

View more on Code Climate.

codecov-io commented 3 years ago

Codecov Report

Merging #1638 (993f2c8) into master (6a124dc) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         126      126           
  Lines        5735     5735           
=======================================
  Hits         5386     5386           
  Misses        349      349

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a124dc...993f2c8. Read the comment docs.

klobuczek commented 3 years ago

thx @joshjordan

neo4jrb / activegraph

Remove unused exception class #1638

Codecov Report