ENV-based login/pass/encryption set

neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.

http://neo4jrb.io

MIT License

1.39k stars 276 forks source link

ENV-based login/pass/encryption set #1643

Closed EugeneIstomin closed 1 year ago

EugeneIstomin commented 3 years ago

This pull introduces/changes:

Add possibility to set login, password, encryption on/off for using migration in non-Rails projects

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit aca9026e and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

View more on Code Climate.

klobuczek commented 3 years ago

Thanks @EugeneIstomin . Have you considered extracting this https://github.com/neo4jrb/activegraph/blob/master/lib/active_graph/railtie.rb#L82-L85 out of railtie.rb? There are many configuration options. Creating an environment variable each time someone needs one of those options doesn't seem like a sustainable solution. It would be great to solve the problem for any possible configuration.