search

neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 277 forks source link

Bring Dockerfile current with "activegraph" naming #1658

Closed RyanSnodgrass closed 3 years ago

RyanSnodgrass commented 3 years ago

Bring the Dockerfile up to date with the current structure of the gem.

  1. Update gemfile directory paths
  2. Follow github actions test and install bundler to latest 2.x version
$ docker build -t activegraph-gem .
codecov-commenter commented 3 years ago

Codecov Report

Merging #1658 (2a066f2) into master (c147001) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 2a066f2 differs from pull request most recent head 08b9bb6. Consider uploading reports for the commit 08b9bb6 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1658   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files         126      126           
  Lines        5683     5683           
=======================================
  Hits         5327     5327           
  Misses        356      356

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c147001...08b9bb6. Read the comment docs.

klobuczek commented 3 years ago

seabolt has been discontinued. The PR in this form should be raised against branch 10 and possibly a different one against master.

RyanSnodgrass commented 3 years ago

@klobuczek What bolt adapter would you recommend?

RyanSnodgrass commented 3 years ago

The PR in this form should be raised against branch 10

done - https://github.com/neo4jrb/activegraph/pull/1659

klobuczek commented 3 years ago

If you stiil would like this PR merge to master remove the seabolt references and use jruby.

RyanSnodgrass commented 3 years ago

I can do that, but why? Will the master branch always be jruby?

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 08b9bb6a and detected 0 issues on this pull request.

View more on Code Climate.

RyanSnodgrass commented 3 years ago

remove the seabolt references and use jruby.

Done