search

neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 277 forks source link

WIP: Rel concurrency issue proving test cases #1704

Closed mrhardikjoshi closed 9 months ago

mrhardikjoshi commented 10 months ago

Bug: When a has_one association of a node is updated concurrently, it does not respect the has_one association and due to race condition it may result in wrong data. This is very low probable scenario.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3c89aef) 93.43% compared to head (c307559) 43.23%.

:exclamation: Current head c307559 differs from pull request most recent head e060bc2. Consider uploading reports for the commit e060bc2 to get more accurate results

Files Patch % Lines
...node/query/query_proxy_methods_of_mass_updating.rb 0.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1704 +/- ## =========================================== - Coverage 93.43% 43.23% -50.20% =========================================== Files 128 106 -22 Lines 5909 4947 -962 =========================================== - Hits 5521 2139 -3382 - Misses 388 2808 +2420 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mrhardikjoshi commented 9 months ago

Closing as the fix for this is merged.