search

neo4jrb / activegraph

An active model wrapper for the Neo4j Graph Database for Ruby.
http://neo4jrb.io
MIT License
1.4k stars 277 forks source link

Generator cleanup with tests #1717

Closed mrhardikjoshi closed 8 months ago

mrhardikjoshi commented 8 months ago

This PR introduces tests on top of changes of #1716

codecov-commenter commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f86d54c) 93.12% compared to head (e496b98) 93.08%.

:exclamation: Current head e496b98 differs from pull request most recent head 2d2f968. Consider uploading reports for the commit 2d2f968 to get more accurate results

Files Patch % Lines
lib/active_graph/railtie.rb 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 11 #1717 +/- ## ========================================== - Coverage 93.12% 93.08% -0.04% ========================================== Files 128 128 Lines 5700 5700 ========================================== - Hits 5308 5306 -2 - Misses 392 394 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mrhardikjoshi commented 8 months ago

update readme file to include command/steps to run e2e tests

mrhardikjoshi commented 8 months ago

To Do Notes: 1) add tests for down migration command 2) add tests for running default rails tests in minitest 3) cleanup and merge both github workflows