Refactoring, cleanup and generalization - Githubissues

neo4jrb / neo4j-core

A simple unified API that can access both the server and embedded Neo4j database. Used by the neo4j gem

MIT License

99 stars 80 forks source link

Refactoring, cleanup and generalization #319

Closed klobuczek closed 5 years ago

klobuczek commented 6 years ago

Fixes # This is a neutral PR that does not introduce any new functionality. It does some refactoring and cleanup and exposes hook methods that are necessary for the java driver adaptor to work properly. This pull introduces/changes:

adds close methods on driver and session
packs shared spec example and a spec helper into the gem for reuse by adaptors in separate gems

Pings: @cheerfulstoic @subvertallchris

coveralls commented 6 years ago

Coverage increased (+1.5%) to 86.15% when pulling 9843f1c74017d5281455b3cccf07636d8a0e5ff5 on klobuczek:java_driver into e4a263999017e1b58570f657351b741c6146d0c8 on neo4jrb:master.

coveralls commented 6 years ago

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

coveralls commented 6 years ago

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

coveralls commented 6 years ago

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

coveralls commented 6 years ago

Coverage decreased (-0.06%) to 84.528% when pulling ae1ec57716bd6fb897305303a6b61dd879fcba10 on klobuczek:java_driver into 5eaa804475508fb56414489c3e3bb5eb1366754a on neo4jrb:master.

klobuczek commented 6 years ago

@cheerfulstoic could we move ahead on that? It is not ideal to point our production to forks and keep synching the fork with upstream.