search

neo618 / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn
0 stars 0 forks source link

log dialog uses wrong file if sorted #108

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=28597
19

I'd like to report a bug affecting the "Revert changes from this
revision" command in the file list view of the log messages window.

Steps to reproduce:
1. Open the log messages window for a directory of your choice.
2. Select a revision with at least two modified files.
3. In the list view showing the modified files, click on the "Path"
    column header twice so the sorting order is reversed.
4. Right-click on one of the items and choose "Revert changes from
    this revision".
5. Notice that in the "Reverting changes" dialog box, the wrong file
    name is displayed.
6. After clicking on "OK", the file that was named in the dialog box
    is reverted and not the selected one.

Original issue reported on code.google.com by tortoisesvn on 21 Oct 2011 at 2:58

GoogleCodeExporter commented 9 years ago 
Note: this affects not just the revert command but others as well.

Original comment by tortoisesvn on 21 Oct 2011 at 2:59

GoogleCodeExporter commented 9 years ago 
This requires quite a lot of work.
Starting...

Original comment by tortoisesvn on 21 Oct 2011 at 4:47

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r22152.

Original comment by tortoisesvn on 21 Oct 2011 at 5:12

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r22156.

Original comment by tortoisesvn on 21 Oct 2011 at 7:48

GoogleCodeExporter commented 9 years ago 
This is not fixed in:

TortoiseSVN 1.7.1, Build 22161 - 64 Bit , 2011/10/21 22:51:59
Subversion 1.7.1, 
apr 1.4.5
apr-utils 1.3.12
neon 0.29.6
OpenSSL 1.0.0e 6 Sep 2011
zlib 1.2.5

Original comment by dsfirth on 10 Nov 2011 at 3:38

GoogleCodeExporter commented 9 years ago 
Not really a useful comment dsfirth. What did you do? What command? Where did 
you right-click? How many items were shown?

Just "not fixed" doesn't help at all.

And maybe it's related to issue #133.

Original comment by tortoisesvn on 10 Nov 2011 at 4:41

GoogleCodeExporter commented 9 years ago 
Follow-up to my previous comment:

I was able to reproduce this issue in v1.7.1, using the steps to reproduce in 
the original report. To re-iterate those steps:

1. Open the log messages dialog and select a revision with changes to multiple 
files.
2. In the list showing modified files, alter the sorting so that the _original_ 
first file is no longer the first file in the list.
3. Right-click the _new_ first file in the list (that is, the one at the top 
AFTER sorting).
4. Click 'Revert changes from this revision'. Notice that the file in the 
Reverting changes dialog shows the _original_ first file and not the one which 
was actually selected.

* NOTE: all right-click are executed against file in the right-clicked position 
of the _original_ sort order, rather than the current sort order (e.g. Open, 
Open with..., Blame, Revert changes from this revision, etc.).

I don't think that this is related to issue #133. I saw the issue when 'Show 
only affected paths' was both checked and unchecked.

Original comment by dsfirth on 14 Nov 2011 at 6:17

GoogleCodeExporter commented 9 years ago 
Thanks for the follow-up. With that recipe I'm able to reproduce the problem.

Original comment by tortoisesvn on 14 Nov 2011 at 7:27

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r22271.

Original comment by tortoisesvn on 14 Nov 2011 at 8:23

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r22273.

Original comment by tortoisesvn on 15 Nov 2011 at 8:25