search

neo618 / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn
0 stars 0 forks source link

custom properties for code review/todo items #63

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Feedback from Subversion Live 2011 in San Jose:
(just a suggestion, this needs a lot of discussions first)

quote from email:

Let me paint a picture:

Your organzation believes in code review.  ie a senior programmer looks a 
junior programmers code and after he reviews it sets the svn property 
"codereview" to passed or failed.  Obviously the code could move in and out of 
these states as it evolves.

The fact that the latest revision of code is marked "codereview:failed" would 
prompth the person responsible for the code to fix it up to coding standards. 
(comments, variable names, indentation etc)
The reviewer can obviously make comments about what is wrong in the Log 
Messages when he/she checks in the code with a changed property.

Where this breaks down is:
1.How does anyone "easily" find out which files (or versions of files) have 
this propert set?
2. It would be nice to be able to limit the property input to the values "pass 
and fail", and it would be even better if these values could be selected.
3. It would be cool if selectively, a user could have a column in the "log 
messages" and "repo-browser" set to a specific property.(like Bug-ID's)
4. Some sort of report would also be nice.

Just passing on ideas.

Original issue reported on code.google.com by tortoisesvn on 3 Feb 2011 at 7:39

GoogleCodeExporter commented 9 years ago 
Such a custom property would have to be much more generic, not just fixed to 
"pass/fail". 

For example could such a property be used to act as a TODO list for files, e.g. 
add an "tsvn:todo" to "needs indentation fixes\nfind better function 
names\nrefactor big function ABCD() into several smaller functions", which each 
line of the property value being one item of the TODO list for that file.

For code reviews, this would mean as long as there's a line left (i.e., the 
property exists) the code review would have state "failed", if the property 
gets removed the state would be again "pass".

another tsvn: property would activate certain features UI-wise, e.g., 
automatically start the property-fetching thread in the CfM dialog and add the 
column, enable a new context menu to show a report view, ...

Original comment by tortoisesvn on 3 Feb 2011 at 7:45

GoogleCodeExporter commented 9 years ago 
See these discussions on the svn dev list about new APIs to fetch all 
properties in a working copy at once:
http://svn.haxx.se/dev/archive-2011-02/0104.shtml
http://svn.haxx.se/dev/archive-2011-01/0188.shtml

Original comment by tortoisesvn on 6 Feb 2011 at 5:37

GoogleCodeExporter commented 9 years ago 
How about adding an option to TortoiseSVN where you can specify a set of 
revision property names, and then a new column for each of these revision 
properties will be added to the Revision Log window?

Original comment by l...@zealake.com on 6 Oct 2011 at 2:13

GoogleCodeExporter commented 9 years ago 
Also see this blog post on how users 'misuse' the issue tracker integration for 
code reviews:
http://www.zealake.com/2011/12/30/lightweight-code-reviews-using-tortoisesvn/

if this issue was implemented, that user could use properties instead of log 
messages.

But: a review of individual commits and not whole files would require revision 
properties, not normal properties.
Since SVN allows custom revision properties as well (but they're not 
versioned!), a review function using those would be possible as well:
tsvn:reviewed = user1,user2,user3

Original comment by tortoisesvn on 31 Dec 2011 at 7:34