search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

feat: Use GlobalContext class #106

Closed Tiboris closed 3 years ago

Tiboris commented 3 years ago

Use GlobalContext class in runtime which allows us to use mrack with only this context and as a library with only creating desired actions Up/Destroy/... and calling them in python scripts.

some minor fixes are also included in this PR

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

pvoborni commented 3 years ago

Before I'll read the code: Why is this "breaking" change needed?

Tiboris commented 3 years ago

@pvoborni Hello, please do not. I need to update this on more places. and add at least one commit.

Why is this "breaking" change needed?

I was trying how semantic-release will behave - after merge next release would be 1.0.0

pvoborni commented 3 years ago

Why is this "breaking" change needed?

The emphasis is not on the "breaking". The question is why is this PR needed? What benefits we expect from it?

Tiboris commented 3 years ago

Tested:

mrack up -m metadata-f30.yaml
mrack ssh -m metadata-f30.yaml
mrack destroy -m metadata-f30.yaml
Tiboris commented 3 years ago

Will do @netoarmando