search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

Enable isort linting #13

Closed netoarmando closed 4 years ago

netoarmando commented 4 years ago

Helper tool to sort the imports for us.

Signed-off-by: Armando Neto abiagion@redhat.com

pvoborni commented 4 years ago

Could be good. I usually run make format for black formatting before commit. Should we add it there as well to sort the imports before black kicks in? So that later the the check will pass?

netoarmando commented 4 years ago

Could be good. I usually run make format for black formatting before commit. Should we add it there as well to sort the imports before black kicks in? So that later the the check will pass?

I've included that as well. Leaving as WIP until we merge https://github.com/pvoborni/mrack/pull/14 so we can run this to fix the imports.

pvoborni commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago
No pipelines are associated with this pull request.
pvoborni commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).
pvoborni commented 4 years ago

Did a quick read through the changes. Looks good to me. Did not test, I'll leave it on Tibor.

Tiboris commented 4 years ago

Thanks for the patch @netoarmando let us merge this!