search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

fix(OpenStack): Changes for AD hostname for the requirement #146

Closed Tiboris closed 2 years ago

Tiboris commented 3 years ago

fix(OpenStack): Use only first part of fqdn for host name

if the host name contains "." character which is not supported for windows OS as host name or the host name is an FQDN we use only first part of domain name as host identifier for openstack

refactor: use builtin operator to merge dictionary

mhcfg section from provisioning-config is default and could be extended by user provided mhcfg section from metadata, thus using this order for | operator

Tiboris commented 2 years ago

Updated to use builtin is_windows_host(host)

Tiboris commented 2 years ago

Hello @pvoborni please have a look on #FIXME comments in code.

Tiboris commented 2 years ago

Also the fact that there are 4 of them in a small commit tells that this PR should not be merged in this state.

The FIXME comments were meant to show why and what change is needed and NOT to point to unfinished work or whatever else you have understood. Lets just say this is a communication issue and we misunderstood each other probably because my comments are not well written.