This is an alternative implementation to https://github.com/neoave/mrack/pull/146 consisting of 3 changes. The actual fix, which is very small + 2 preparations where refactoring to pass the req is the biggest.
fix(openstack): use shortnames for Windows vm names
Windows machines get hostname often by Cloudbase-Init. But
windows host support setting only shortnames (domain is added
when the host joins AD domain). OpenStack derives the hostnane
from vm name (until nova version 2.90 where hostname attr is added).
Thus we set shortname to support this also on older OpenStacks.
feat: add shortname in Ansible inventory output
It is added in meta_hostname attribute as often shortnames are
referred as hostnames.
refactor: pass req to to_host method
Or in other words, do not loose it/return it from
wait_till_provisioned method.
That way a provider can loose all info about req
even the host name and to_host will still have this
info accessible.
This is an alternative implementation to https://github.com/neoave/mrack/pull/146 consisting of 3 changes. The actual fix, which is very small + 2 preparations where refactoring to pass the
reqis the biggest.fix(openstack): use shortnames for Windows vm names Windows machines get hostname often by Cloudbase-Init. But windows host support setting only shortnames (domain is added when the host joins AD domain). OpenStack derives the hostnane from vm name (until nova version 2.90 where hostname attr is added). Thus we set shortname to support this also on older OpenStacks.
feat: add shortname in Ansible inventory output It is added in meta_hostname attribute as often shortnames are referred as hostnames.
refactor: pass req to to_host method Or in other words, do not loose it/return it from wait_till_provisioned method.
That way a provider can loose all info about req