fix(Openstack): raise Validation error when req has undefined network type

[Tiboris]

when bogus network appear in metadata requirement mrack continues and pass the network: None to the openstack server as requirement thus it fails This should fix the problems with networks that are not defined/supported in provisioning-config.yaml

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

[pvoborni]

When I was looking deeper into this. I think that https://github.com/neoave/mrack/pull/117 introduced a regression where user cannot set network directly in metadata via: networks: my_osp_network entry. There reason is that move of the code caused that names = host.get("networks") on https://github.com/neoave/mrack/blob/master/src/mrack/providers/openstack.py#L186 will be always None as networks is not part of req. See https://github.com/neoave/mrack/blob/master/src/mrack/transformers/openstack.py#L65 It's because previously the host was host entry from metadata file. But in provider it is a req.

Wrt this patch. This kind of validation should be done in transformer Probably on line 50 https://github.com/neoave/mrack/blob/master/src/mrack/transformers/openstack.py#L50

[Tiboris]

I will have a look into that @pvoborni

[Tiboris]

This patch is no longer valid.