neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
11 stars 14 forks source link

feat: multiple aws enhancements (PrivateIPAddress, multiple security groups, Subnet) #159

Closed pvoborni closed 2 years ago

pvoborni commented 2 years ago

Requires: https://github.com/neoave/mrack/pull/158

feat(aws): support for PrivateIpAddress

When instance is provisioned with VPC which does not have a public IP address, mrack is not able to get IP and fails. So changing the behavior to try also Private IP if Public is not present.

feat(aws): subnet support

Adding possibility to define subnet to use for the instances. This is needed, e.g. when instance needs to use a non-default VPC.

feat(aws): multiple security groups

Add support to be able to use multiple security groups and thus be able to fine tune the inbount and outbound commnucation rules.

Note: there might be a small regression in validation in multiple security groups patch, where there is a possibility for alternate definitions but one is required and the other not. Not sure if we want to fix it - thus up to comments.

Tiboris commented 2 years ago

Can we rebase?