search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
11 stars 14 forks source link

Load the requirements.txt in setup.py #16

Closed Tiboris closed 4 years ago

Tiboris commented 4 years ago

Load the content of requirements.txt file instead of having static list in setup.py

Resolves https://github.com/pvoborni/mrack/issues/15

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

netoarmando commented 4 years ago

Should we also include the packages from: https://github.com/pvoborni/mrack/blob/8ec7bf98391adb4bc02de381268577f857bbdd0a/azure-pipelines.yml#L26

Maybe as test or dev requirements.

pvoborni commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).
pvoborni commented 4 years ago

Should we also include the packages from:

https://github.com/pvoborni/mrack/blob/8ec7bf98391adb4bc02de381268577f857bbdd0a/azure-pipelines.yml#L26

Maybe as test or dev requirements.

We should probably add them to test-requirements.txt But my "Python good practices knowledge" is limited here.

Tiboris commented 4 years ago

We should probably add them to test-requirements.txt But my "Python good practices knowledge" is limited here.

Yes I do agree. We should have all requirement to test locally in test-requirements.txt and if something more is needed in azure pipeline we should add it in azure's yaml.

netoarmando commented 4 years ago

@Tiboris +1 to your proposal, I think you should include that to this PR.