neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

feat(Beaker): Support custom configurable ks_meta values #184

Closed Tiboris closed 2 years ago

Tiboris commented 2 years ago

get the ks_meta from host configuration, global provisioning config or default hardcoded in code. The priority is following:

pvoborni commented 2 years ago

Approved. It works. Looks OK. But have a Q: Why is one key named ks_meta and the other kickstart_metadata shouldn't it be the same, or is there some other specific reason?

Tiboris commented 2 years ago

To reply to above comment the reason is just that it is more readable in my opinion ks_meta is variable passed to provider which is supported to it but it is basically kickstart_metadata which user can pass as a string. If that's not what we want we can rename it to ks_meta of course.

pvoborni commented 2 years ago

We can merge this. My only worry is that it will confuse users. Time will tell.