feat(AWS): Add multiple subnet support & IPs availability check

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development

Apache License 2.0

11 stars 14 forks source link

feat(AWS): Add multiple subnet support & IPs availability check #201

Closed dav-pascual closed 1 year ago

dav-pascual commented 1 year ago

Now mrack expects either subnets_id (prioritized) or subnet_id field in the provisioning config file in AWS key field. A list of subnets can be specified where host can be provisioned. It is expected that the subnets are in the same VPC.
mrack checks that the amount IPs available with all the subnets specified are enough to provision all the host concurrently. Otherwise provisioning will retried after a wait and/or cancelled.
Add rule to pylintrc file to allow more local variables in methods.

Signed-off-by: David Pascual davherna@redhat.com

dav-pascual commented 1 year ago

Another note: I went with the most flexible solution, that is, The amount of IPs available for provisioning will be the sum of the available IPs in the provided subnets.

dav-pascual commented 1 year ago

I added changes that I reviewed with @Tiboris I remade can_provision function algorith so now it's possible to specifiy subnets either in metadata or provisioning config, and ip availabilities info from the AWS is saved to a data structure, so it's not necessary to call the API more than once.. I left code comments that should be explanatory of the code.

Tiboris commented 1 year ago

Thanks for the patience all the changes and the feature. lets merge this @dav-pascual !

dav-pascual commented 1 year ago

Thanks for your feedback and review!! @Tiboris :)