search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
11 stars 14 forks source link

feat(openstack-aws): Add owner/lifetime info in VM's metadata #207

Closed kaleemsiddiqu closed 1 year ago

kaleemsiddiqu commented 1 year ago

Owner and lifetime info will be added into VM's metadata for Openstack/AWS providers. This info will give info who owns the VM and what is the lifetime of the VM which will be used for notifying owners and cleaning up the resources based on lifetime of the VMs. If owner info not fetched, user notified with custom error message for follow up action to take up.

Signed-off-by: ksiddiqu ksiddiqu@redhat.com

Tiboris commented 1 year ago

First of all thanks for the PR very much. Let us re-visit changes.

Just a note also a title of PR must comply with commit message check i have changed it a bit. Fist note if possible could you divide this to commit per provider change?

kaleemsiddiqu commented 1 year ago

First of all thanks for the PR very much. Let us re-visit changes.

Just a note also a title of PR must comply with commit message check i have changed it a bit. Fist note if possible could you divide this to commit per provider change?

Updated code in two commits

Tiboris commented 1 year ago

@kaleemsiddiqu could you please also add line (with some comment)

require-owner = true

to the https://github.com/neoave/mrack/blob/main/src/mrack/data/mrack.conf ?

Tiboris commented 1 year ago

Thanks @kaleemsiddiqu for all the changes you did and updates. I would like to kindly ask you to change the spec file to add:

Recommends:       python3-gssapi

after line https://github.com/neoave/mrack/blob/main/mrack.spec#L46 which will create weak dependency on the package.

With addition to setup.py (https://github.com/neoave/mrack/blob/main/setup.py#L56 ) :

    extras_require={
        "krb-owner": ["gssapi"],
    },