search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
11 stars 14 forks source link

fix: make db file and provisioning file optional #219

Closed Tiboris closed 1 year ago

Tiboris commented 1 year ago

When initializing the global context these files should be passed to the init as optional param when path is specified in mrack cli tool. Otherwise mrack should only load the data from the mrack.conf file records and rely on paths set there for db and provisioning-config.

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

pvoborni commented 1 year ago

What is the context/purpose of this? Don't know what problem it solves.

pvoborni commented 1 year ago

That said the code looks good to me and it seems that the method was written in a way to have this optional.

Tiboris commented 1 year ago

When initializing the global context we might want to only use mrack.conf file which without optional params was not possible. It would be really useful when using mrack as lib to have one source of truth and no need to pass 3 options to lib call.