test: fix installation of right package in smoke tests

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development

Apache License 2.0

11 stars 14 forks source link

test: fix installation of right package in smoke tests #231

Closed pvoborni closed 1 year ago

pvoborni commented 1 year ago

The smoke test is uninstalling all packages and then trying to install them again to check if dependencies work correctly.

The issue is that version of package created by packit on pull request could be lower from dnf PoV than the one available e.g. in EPEL thus the EPEL version is used istead of the one which we are testing.

Thus c8s test is failing as it is picking up a package which has incorrect dependencies.

This PR is recording the initially installed package version to use it again on reinstallation and thus avoid the issue.

Signed-off-by: Petr Vobornik pvoborni@redhat.com

pvoborni commented 1 year ago

I've updated it yet-again as dev.{PACKIT_PROJECT_BRANCH} was still lower than e.g. someting which started with 1.

$ rpmdev-vercmp 1.12.3-dev.pr231 1.12.3-1.20230126174817469017.pr231.4.g887f46d
1.12.3-dev.pr231 < 1.12.3-1.20230126174817469017.pr231.4.g887f46d

$ rpmdev-vercmp 1.12.3-99.dev.pr231 1.12.3-1.20230126174817469017.pr231.4.g887f46d
1.12.3-99.dev.pr231 > 1.12.3-1.20230126174817469017.pr231.4.g887f46d

pvoborni commented 1 year ago

In general, I think that we have 2 ways to solve the issue

either have high release number, e.g. the 99 as proposed here. The Q is whether it should be in spec or packit config. I chose packit config as I was not sure how koji update works with it and thus 'pull_request' in packit config should not affect it
alternative solution would be to have higher version in git than the last release. I.e. bump it after release, but this may not work well with semantic releases functionality (assuming here). Thus the former was chosen.