Closed pbrezina closed 1 year ago
The test pass locally fine. I do not know why it fails and the log does not provide any clue. Are you able to reproduce it?
Hello @pbrezina, thanks for the patches! I would like to kindly ask you to change your commit messages so they are valid for our automation see run https://github.com/neoave/mrack/actions/runs/4223470841/jobs/7353482982
Currently we support (see error message):
Error: Error: Commit message should match the '<type>(<scope>): <subject>' style
for python-semantic-release supported types:
feat: A new feature
fix: A bug fix
docs: Documentation only changes
style: Changes that do not affect the meaning of the code (white-space, formatting, missing chars...)
refactor: A code change that neither fixes a bug nor adds a feature
perf: A code change that improves performance
test: Adding missing or correcting existing tests
chore: Changes to the build process or auxiliary tools and libraries such as documentation generation
so in you case eg: refactor(black) ; feat(outputs) etc.
Done.
Could you please rebase ? I will try to pull the code and run tests locally.
Rebased.
Please, don't push it yet. I will probably also add the domain name into the configuration.
@pvoborni It is ready for final review. I change the "type" in pytest-mh to "id" (taken from domain["name"]).
Additionally, I needed to relax condition in get_fqdn so the domain does not have to match. I assume it is ok, I can avoid using get_fqdn if not. This is in "feat(utils): relax condition in get_fqdn"
I amended https://github.com/neoave/mrack/pull/242/commits/dcaf0bc99704a773a062f63ceba275dd9e2a60c3 to catch also case when there are more nested groups. In this case, it would only successfully find the last one. Line 77 was changed and test was extended.
Now it is ready to push.
This adds new output for pytest-mh configuration file. Pytest-mh is a complete rewrite of pytest-multihost with additional features that is going to be used by SSSD. See: https://pytest-mh.readthedocs.io
This PR also adds
config
section to metadata file that currently can contain:outputs
: list of output files, defaults to"anisble-inventory", "pytest-multihost
ansible/layout
: to overwrite inventory_layout from provisioning-config