search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
11 stars 14 forks source link

feat(outputs): merge nested dictionary instead of overriding it #256

Closed pbrezina closed 1 year ago

pbrezina commented 1 year ago

pytest-mh configuration may contain nested dictionary, specifying username or password in pytest_mh section will result in overriding the host option, i.e.:

pytest_mh:
  ssh:
    username: tuser
    password: tuserpassword

will generate wrong configuration where ssh/host is not set.

This patch makes sure that the ssh key is merged instead of overwritten.

pvoborni commented 1 year ago

The packit tests fails as the spec file is missing the new python dependency. But even if added, I think it will fail on it missing in epel.

pbrezina commented 1 year ago

The packit tests fails as the spec file is missing the new python dependency. But even if added, I think it will fail on it missing in epel.

Ok, I removed the dependency and implement the function from scratch.

Tiboris commented 1 year ago

@pbrezina could you please re-push with a rebase all three commits with different hashes as TF thinks there are still old change there?

pbrezina commented 1 year ago

Done. I also added test for the windows case.

pbrezina commented 1 year ago

/packit test

pbrezina commented 1 year ago

Packit still tries to find "mergedeep" package but there is no reference to it in my commits...

pvoborni commented 1 year ago

@Tiboris I'd approve and merge this PR even if the packit fails as it doesn't seem to be related. WDYT?

It looks like we need to improve packit config to include some kind of timestamp in package version so that newer build would be created+used by packit.