search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

fix: Do not reprovision all hosts when server error is detected #263

Closed Tiboris closed 1 year ago

Tiboris commented 1 year ago

when 500 code is detected in the error state of the errored VM mrack would aggressively remove all hosts which have been already provisioned properly. Changing logic that if only a certain percentage of errored hosts is reached.

fix: Use lower cooldown time to not be too slow in re-provisioning

dav-pascual commented 1 year ago

I think this looks good, thanks

Probably a testcase for the high share of failed hosts case would be nice. Should be quick modifying one of the existing ones :)

Tiboris commented 1 year ago

@dav-pascual Added test

dav-pascual commented 1 year ago

@Tiboris Thanks for the test. LGTM