search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

chore(ci): Fix release workflow build step checking out wrong commit #275

Closed dav-pascual closed 1 year ago

dav-pascual commented 1 year ago

actions/checkout checks out the latest commit at the time of the workflow trigger, hence any commit done during the workflow is not included. Fixing this to checkout the actual latest (release) commit.

dav-pascual commented 1 year ago

Tested in https://github.com/dav-pascual/mrack/actions/runs/6417183083

Job checking out the actual latest release commit at step https://github.com/dav-pascual/mrack/actions/runs/6417183083/job/17422433550#step:3:44

Commit done: https://github.com/dav-pascual/mrack/commit/c0fc82eec7878d45edbd95f4c219684f8747f19d

pvoborni commented 1 year ago

I don't understand how does this fix #273. There, the issue seems to be:

404 Client Error: Not Found for url: https://github.com/neoave/mrack/releases/download/v1.16.0/mrack-1.16.0.tar.gz

I.e. the release process did not upload the archive here: https://github.com/neoave/mrack/releases/tag/v1.16.0

But how does the checkout fix it? I was looking at latest test&release run: https://github.com/neoave/mrack/actions/runs/6406506972 and that seems to fail on the fact the version was not bumped as the commit used "chore" type in commit (i think that "chore" doesn't bump version") it would need to be fix, feat or something else.

The fact that the workflow runs with the version it was executed on seems good to me. Or what is the issue with it?

dav-pascual commented 1 year ago

I don't understand how does this fix #273. There, the issue seems to be:

404 Client Error: Not Found for url: https://github.com/neoave/mrack/releases/download/v1.16.0/mrack-1.16.0.tar.gz

I.e. the release process did not upload the archive here: https://github.com/neoave/mrack/releases/tag/v1.16.0

But how does the checkout fix it? I was looking at latest test&release run: https://github.com/neoave/mrack/actions/runs/6406506972 and that seems to fail on the fact the version was not bumped as the commit used "chore" type in commit (i think that "chore" doesn't bump version") it would need to be fix, feat or something else.

The fact that the workflow runs with the version it was executed on seems good to me. Or what is the issue with it?

@pvoborni Oops, didn't look at the packit logs and thought it was about the same issue. I'll unlink the issue.

The workflow run you looked at, indeed won't upload the new version to pypi because @Tiboris already did so manually. In that workflow it also gets the right version (1.16.0) because the release commit was done in a previous workflow run, so the commit "is there" when the workflow starts: https://github.com/neoave/mrack/actions/runs/6406506972/job/17391355353#step:12:61

Look at this workflow run: https://github.com/neoave/mrack/actions/runs/6241434877 It's doing semantic release for 1.16 version, but it's trying to publish 1.15.1 because it didn't get the latest release commit done during the semantic release step.