search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

spec is bit out of order #282

Closed tdudlak4918ab closed 3 weeks ago

tdudlak4918ab commented 11 months ago

the specfile contains release twice 1.16.0-1:

* Mon Oct 09 2023 David Pascual Hernandez <davherna@redhat.com> - 1.16.0-1
- e8e20f1 chore(ci): Fix release workflow build step checking out wrong commit (David Pascual)
- 97a7cd0 chore: Bump asyncopenstackclient dependency version (David Pascual)
- 41b12e7 chore: Release version 1.16.0 (github-actions)
- 278d1b1 chore(release): Add PyPI action & extract copr step (Tibor Dudlák)
- 9bbd987 chore: Bump python-semantic-release to v7.34.4 (Tibor Dudlák)
- d6b7298 feat: Add new dependecies to mrack.spec file (David Pascual)
- 7bbda34 feat(OpenStack): Add clouds.yaml as an authentication method (David Pascual)
- a5b32e3 feat(OpenStack): Import publick key on provision (David Pascual)
- 1a29d86 test: fix pylint issues and use isinstance (Tibor Dudlák)
- db74ae0 fix(Beaker): Exception has been thrown as raise missed argument (Tibor Dudlák)
- de027fa docs(Beaker): Add hostRequires documentation section to guides (David Pascual)

* Tue Sep 19 2023 Tibor Dudlák <tdudlak@redhat.com> - 1.16.0-1
- 278d1b1 chore(release): Add PyPI action & extract copr step (Tibor Dudlák)
- 9bbd987 chore: Bump python-semantic-release to v7.34.4 (Tibor Dudlák)
- d6b7298 feat: Add new dependecies to mrack.spec file (David Pascual)
- 7bbda34 feat(OpenStack): Add clouds.yaml as an authentication method (David Pascual)
- a5b32e3 feat(OpenStack): Import publick key on provision (David Pascual)
- 1a29d86 test: fix pylint issues and use isinstance (Tibor Dudlák)
- db74ae0 fix(Beaker): Exception has been thrown as raise missed argument (Tibor Dudlák)
- de027fa docs(Beaker): Add hostRequires documentation section to guides (David Pascual)

may I kindly ask you @dav-pascual to see which section is correct and remove broken one?

image there might be an issue when only fix commits are present and version is pre-loaded wrong way... i think this might be fixed please check but at least in changelog could you plase change version to 1.16.1 if even correct or.... just merge commit history in this section... I can try to check at evening...

maybe this is how it should look like:

* Mon Oct 09 2023 David Pascual Hernandez <davherna@redhat.com> - 1.16.0-1
- e8e20f1 chore(ci): Fix release workflow build step checking out wrong commit (David Pascual)
- 97a7cd0 chore: Bump asyncopenstackclient dependency version (David Pascual)
- 41b12e7 chore: Release version 1.16.0 (github-actions)
- 278d1b1 chore(release): Add PyPI action & extract copr step (Tibor Dudlák)
- 9bbd987 chore: Bump python-semantic-release to v7.34.4 (Tibor Dudlák)
- d6b7298 feat: Add new dependecies to mrack.spec file (David Pascual)
- 7bbda34 feat(OpenStack): Add clouds.yaml as an authentication method (David Pascual)
- a5b32e3 feat(OpenStack): Import publick key on provision (David Pascual)
- 1a29d86 test: fix pylint issues and use isinstance (Tibor Dudlák)
- db74ae0 fix(Beaker): Exception has been thrown as raise missed argument (Tibor Dudlák)
- de027fa docs(Beaker): Add hostRequires documentation section to guides (David Pascual)
dav-pascual commented 11 months ago

thanks for reporting Tibor, will take as look as well :)

tdudlak4918ab commented 11 months ago

image so there is no 1.16.1 .... sory for confusion

dav-pascual commented 11 months ago

It also seems that there are two 1.16.0 release commits and in [1] changelog format was broken (see bottom of the changelog).

It looks like it does not happen anymore after the release was fixed, so we just need to manually fix these files.

[1] https://github.com/neoave/mrack/commit/41b12e7f8d9e34a2b5f3da856b9426bf528670ec#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed

Tiboris commented 11 months ago

yes, this is what i meant, good catch

Tiboris commented 9 months ago

/packit propose-downstream

Tiboris commented 3 weeks ago

Thanks for fixing it in fedora