feat: handle list value for add_dict_to_node function

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development

Apache License 2.0

12 stars 14 forks source link

feat: handle list value for add_dict_to_node function #292

Closed skycastlelily closed 6 months ago

skycastlelily commented 6 months ago

fix this issue:https://github.com/neoave/mrack/issues/291 :)

pvoborni commented 6 months ago

Hi, could you also add a unit test that verifies that the use case in #291 works? That the resulting xml is as expected and that the beaker client accepts it.

skycastlelily commented 6 months ago

Updated,Sorry for the late reply,I was on National holiday again,it's outing season here:)

On Tue, Apr 30, 2024 at 10:24 PM Petr Vobornik @.***> wrote:

Hi, could you also add a unit test that verifies that the use case in #291 https://github.com/neoave/mrack/issues/291 works? That the resulting xml is as expected and that the beaker client accepts it.

— Reply to this email directly, view it on GitHub https://github.com/neoave/mrack/pull/292#issuecomment-2085468710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFR23EVX44P4AWRUR47RS3Y76SQZAVCNFSM6AAAAABG55T44SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVGQ3DQNZRGA . You are receiving this because you authored the thread.Message ID: @.***>

skycastlelily commented 6 months ago

Sure,updated:)

On Tue, May 7, 2024 at 7:09 PM Petr Vobornik @.***> wrote:

@.**** commented on this pull request.

the code LGTM, but please fix the lint issues highlighted by CI:

title of the test commit

flake8 check https://dev.azure.com/neoave/mrack/_build/results?buildId=1153&view=logs&jobId=e4354d11-29aa-59c2-ce04-0d9aced3ea05&j=e4354d11-29aa-59c2-ce04-0d9aced3ea05&t=37a28340-749f-5255-d3d8-b83a7b4239ca

— Reply to this email directly, view it on GitHub https://github.com/neoave/mrack/pull/292#pullrequestreview-2042880909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFR23B47KZXIFDRHDXMOETZBCY7VAVCNFSM6AAAAABG55T44SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBSHA4DAOJQHE . You are receiving this because you authored the thread.Message ID: @.***>

skycastlelily commented 6 months ago

Thanks:)

On Tue, May 14, 2024 at 4:11 PM Petr Vobornik @.***> wrote:

Merged #292 https://github.com/neoave/mrack/pull/292 into main.

— Reply to this email directly, view it on GitHub https://github.com/neoave/mrack/pull/292#event-12797745529, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFR23GATN2YK433N5ERFPTZCHAEVAVCNFSM6AAAAABG55T44SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG44TONZUGU2TEOI . You are receiving this because you authored the thread.Message ID: @.***>