search

neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

Add docs on how to set credentials #43

Closed netoarmando closed 4 years ago

netoarmando commented 4 years ago

Quick guide on how set credentials for current supported providers.

Signed-off-by: Armando Neto abiagion@redhat.com

pvoborni commented 4 years ago

Did a quick read and it looks good to me. Though I don't say that I followed the instructions so if it is bad then I did not noticed that :).

pvoborni commented 4 years ago

I wonder if we can somehow build the documentation in PRs, so that we can also check if it looks good.

netoarmando commented 4 years ago

I wonder if we can somehow build the documentation in PRs, so that we can also check if it looks good.

We can, but when I ran make html with a typo instead the correct path to credentials.rst, the output was helpful to detect the error; however, the return code was always 0.

pvoborni commented 4 years ago

One thing is pass the build. This should be added to Azure. But I also though, if e.g. read the docs or something else can build the branch so that we can see how it actually looks, e.g. if it is correctly formatted - without a need to check it out locally, build it and see it.

pvoborni commented 4 years ago

In any case, I don't have any problem with merging this PR.

netoarmando commented 4 years ago

@pvoborni @Tiboris I added a basic support to build docs and save them into Azure's artifacts.