neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
11 stars 14 forks source link

Do not set username for pytest multihost config #52

Closed pvoborni closed 3 years ago

pvoborni commented 3 years ago

We have actually not used it at it cannot be assumed that the user used for provisioning should be used for pytest-multihost.

E.g. a lot of tests rely on root - to be able to completely control the remote machine. That cannot be done, e.g. with default cloud-user.

(Though it can often sudo to root)

Let's keep there the more simple configuration, where user is the same for all host and is defined in provisioning config 'mhcfg' dir.

Signed-off-by: Petr Vobornik pvoborni@redhat.com

pvoborni commented 3 years ago

Is there a reason for squashing them? To a certain degree they could be a separate PRs.

Tiboris commented 3 years ago

Nevermind.