neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
11 stars 14 forks source link

Fix ssh action and improve its error UX #53

Closed pvoborni closed 3 years ago

pvoborni commented 3 years ago

Fix OpenStack provisioning status translation

It is not needed to use a STATUS_MAP for translation status in
prov_result_to_host_data as it is done also in to_host of parent
class. Double translation doesn't work and thus everything provisioned
had incorrecly status : "other".

This has then a negative effect on ssh actione where no host is reported
as active.

Signed-off-by: Petr Vobornik <pvoborni@redhat.com>

Do not show traceback on ApplicationError

So that, e.g., on ssh action, when there are no active host, user
will not get an exception ending with:

```
raise ApplicationError("No active host available.")
```

But only:
```
No active host available.
```

Which is more user friendly.

Signed-off-by: Petr Vobornik <pvoborni@redhat.com>