neoave / mrack

Multicloud use-case based multihost async provisioner for CIs and testing during development
Apache License 2.0
12 stars 14 forks source link

chore: Add check-commits action for commits #60

Closed Tiboris closed 3 years ago

Tiboris commented 3 years ago

Checks the future commit headers to be compatible with the project python-semantic-release.

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

Tiboris commented 3 years ago

@pvoborni @netoarmando seems like the check have not checked https://github.com/neoave/mrack/pull/60/commits/99decb740b40a2db0403e6c93a2012b3f59241a1 I will try to fix it.

Tiboris commented 3 years ago
Signed-off-by: Tibor Dudlák <tdudlak@redhat.com>"
- OK: "chore: Add check-commits action for commits

Checks the future commit headers to be compatible with
the project python-semantic-release.

Signed-off-by: Tibor Dudlák <tdudlak@redhat.com>"
- failed: "Subject
Problem
Solution

Signed-off-by: Tibor Dudlák <tdudlak@redhat.com>"
Error: Error: Commit message should match the '<type>(<scope>): <subject>' style 
 for python-semantic-release supported types:
 feat: A new feature
 fix: A bug fix
 docs: Documentation only changes
 style: Changes that do not affect the meaning of the code (white-space, formatting, missing chars...)
 refactor: A code change that neither fixes a bug nor adds a feature
 perf: A code change that improves performance
 test: Adding missing or correcting existing tests
 chore: Changes to the build process or auxiliary tools and libraries such as documentation generation
Tiboris commented 3 years ago

Now it should work as expected.