neocities / neocities-ruby

The Neocities Gem - A CLI and library for using the Neocities web site API.
https://neocities.org
52 stars 14 forks source link

Handle special characters on pull #54

Closed wayword-dev closed 4 months ago

wayword-dev commented 4 months ago

Was testing out pull when testing my whirly dependency PR and discovered that it doesn't handle spaces in file names correctly. This PR resolves that.

Example error (with site name redacted):

$ neocities pull
😿  Retrieving files for my-site                               

A fatal error occurred :-(
bad URI(is not URI?): "https://my-site.neocities.org/file with space.html"

As far as I can tell, there is no escaping in the list endpoint in the API:

kyledrake commented 4 months ago

Thank you