neoclide / coc-eslint

Eslint extension for coc.nvim
MIT License
396 stars 25 forks source link

"eslint.run": "onSave" doesn't work as before #106

Closed andbar-ru closed 3 years ago

andbar-ru commented 3 years ago

Thanks for your work!

I have this option in coc-settings.com

"eslint.run": "onSave"

Until updating to the last versions of coc.nvim and all extensions, diagnostics was being updated after every file saving. Now diagnostics is being updated every time I leave insert mode. Diagnostics messages refer to tsserver and vetur. I assume that "onSave" works correctly for what concerns eslint and tsserver and vetur are beyond of coc-eslint responsibility. But before last updating this configuration option prevented messages from tsserver and vetur until file saving.

My coc-settings.json

coc-settings.json {
"coc.preferences.colorSupport": false,
"coc.preferences.currentFunctionSymbolAutoUpdate": false,
"coc.preferences.formatOnSaveFiletypes": ["go"],
"coc.preferences.messageLevel": "error",
"codeLens.enable": true,
"diagnostic.errorSign": "E",
"diagnostic.hintSign": "H",
"diagnostic.infoSign": "I",
"diagnostic.virtualText": false,
"diagnostic.warningSign": "W",
"eslint.quiet": true,
"eslint.run": "onSave",
"eslint.validate": ["javascript", "typescript", "vue"],
"python.jediEnabled": true,
"python.linting.enabled": true,
"python.linting.flake8Args": ["--max-line-length=120"],
"python.linting.flake8Enabled": true,
"python.linting.flake8Path": "/usr/bin/flake8",
"python.linting.pylintEnabled": false,
"signature.hideOnTextChange": true,
"suggest.autoTrigger": "none",
"suggest.noselect": false,
"vetur.useWorkspaceDependencies": true,
"vetur.validation.template": false
}

UPDATE: messages from tsserver and vetur happen even if I disable coc-eslint in CocList extensions menu.

chemzqm commented 3 years ago

It's expected

chemzqm commented 3 years ago

Language server doesn't provide lint on save