neoclide / coc-tabnine

Tabnine integration of coc.nvim
468 stars 18 forks source link

Make suggestions normal completions and not snippets #36

Closed ghost closed 4 years ago

ghost commented 4 years ago

According to #35 the reason coc-tabnine can't be previewed and completed using the same key is because the suggestions are for snippets.

It would be better if they weren't snippets.

chemzqm commented 4 years ago

If they weren't snippets they could be less useful, you can always use <C-y> to confirm completion instead just use <tab> is bad idea IMO.

ghost commented 4 years ago

Why would they be less useful if they weren't snippets?

I would still prefer for tab to complete the suggestions.

sQVe commented 4 years ago

The whole idea behind TabNine is to the to complete whole lines or as much as possible, intelligently. To remove the snippet functionality would disable this feature.

ghost commented 4 years ago

The whole idea behind TabNine is to the to complete whole lines or as much as possible, intelligently. To remove the snippet functionality would disable this feature.

why?

When the PUM shows tabnine options, they are always things like

f(first, second)
public void Function3(
new List<Type>();

They never have empty placeholders in them, as I'd expect snippets to.

I don't understand why you both seem to feel that it's a requirement that tabnine complete to snippets.

sersorrel commented 3 years ago

I also don't understand this.

What benefit does marking the tabnine completions as "snippets" actually have? As far as I can tell, all it does is mean that the completion doesn't happen until you press <cr>, as well as put the cursor in a weird place afterwards.

ghost commented 3 years ago

Please can you teach us how to configure coc-tabnine to insert the entire suggestion text on tab press?

ghost commented 3 years ago

@sQVe

The whole idea behind TabNine is to the to complete whole lines or as much as possible, intelligently.

Because tabnine always provides complete suggestions, why does coc-tabnine only fill in part of the suggestion instead of all of it?