neoclide / coc-tsserver

Tsserver extension for coc.nvim that provide rich features like VSCode for javascript & typescript
MIT License
1.05k stars 68 forks source link

toResource should return zipfile:// urls when using go to definition with yarn PnP #360

Closed clhuang closed 2 years ago

clhuang commented 2 years ago

with the neovim change to expect zipfile:// urls instead of zipfile: urls, the current toResource implementation does not work with going to definitions inside of zipfiles.

As far as I can tell, attempting to change the tsserver sdk in https://github.com/cometkim/berry/blob/master/.yarn/sdks/typescript/lib/tsserver.js#L80 will not work, as the use of Uri compresses any form of zipfile:/// into zipfile:/, requiring a bypass of the current logic.