search

neoclide / coc-tsserver

Tsserver extension for coc.nvim that provide rich features like VSCode for javascript & typescript
MIT License
1.06k stars 68 forks source link

[feature request]Add linkedEditing LSP feature #423

Closed qiqiboy closed 1 year ago

qiqiboy commented 1 year ago

Typescript already supports linkedEditing(not yet released, but available in v5.1.0-dev.20230409).

fannheyward commented 1 year ago

This is the server side support, right? coc.nvim already has linkedEditing support, you can enable it by setting coc.preferences.enableLinkedEditing to true.

qiqiboy commented 1 year ago

I tried it, but didn't work. The coc-html works fine. I searched 'linkedediting' in coc-html, and found some relevant codes. So I think there should be some adaptation work to be done.

fannheyward commented 1 year ago

Got your point, but that PR is for TypeScript, coc-tsserver is something like https://github.com/microsoft/vscode/tree/main/extensions/typescript-language-features and , let's see how VSCode handle this in typescript-language-features.

https://github.com/search?q=repo%3Amicrosoft%2Fvscode+linkedediting&type=code&p=1

Only html-language-features supports linkedEditing in VSCode for now, same as coc-html.

qiqiboy commented 1 year ago

From vscode's April iteration plan, this feature will be released in early May. The maintainers of vscode are already working on it: https://github.com/mjbvz/vscode/commit/2d63e7c1d0c8a260ab605c47f5361e40b6c900b2.

fannheyward commented 1 year ago

https://github.com/microsoft/vscode/pull/176279