neoclide / coc.nvim

Nodejs extension host for vim & neovim, load extensions like VSCode and host language servers.
Other
24.47k stars 956 forks source link

Support change some configure to set initializing message position. #3875

Closed yaocccc closed 2 years ago

yaocccc commented 2 years ago

5JUM2CQOV__H9C}ZR}%NZ_B

Now initializing message position is buttom right floating. I hope it could be set by myself.

floating, echo, or none

chemzqm commented 2 years ago

It should be disabled by default, seems coc-pyright enables it, send feature request to coc-pyright for configurtion to disable the notification. @fannheyward

yaocccc commented 2 years ago

It should be disabled by default, seems coc-pyright enables it, send feature request to coc-pyright for configurtion to disable the notification. @fannheyward

Hi, I tryed remove some coc plugin includes coc-pyright but it seem not work.

I try go、vue、js/ts、py、lua and more filetype,It have same

yaegassy commented 2 years ago

@yaocccc If progressOnInitialization is true in the language server related part of the extension, the progress window will be displayed.

To change this behavior, a configuration must be added on the extension side that wraps progressOnInitialization to true/false.

fannheyward commented 2 years ago

@yaegassy @yaocccc coc-pyright will add a configuration to toggle the progress.

yaocccc commented 2 years ago

Thanks, I get it

I set coc-go, coc-pyright, and coc-volar progressOnInitialization is false it worked.

Suggest coc could have a configuration to change this behavior on initialization.

@chemzqm

Please keep this issues

yaegassy commented 2 years ago

@yaocccc coc-volar has just added a setting to control it. https://github.com/yaegassy/coc-volar/pull/168

chemzqm commented 2 years ago

We won't, you can change the code.

yaocccc commented 2 years ago

Thanks

fannheyward commented 2 years ago

@chemzqm there're two progress parts:

  1. progressOnInitialization
  2. workDoneProgress

For the first one, coc has disabled it by default, and extensions can provides configurations to enable or not, but coc can't disable the second by now.

chemzqm commented 2 years ago

but coc can't disable the second by now.

It could, add "progress" in "disabledFeatures"

fannheyward commented 2 years ago

Oh I missed disabledFeatures.

zoumi commented 2 years ago

clangd has same problem and the popup window is ugly.. image

yaocccc commented 2 years ago

clangd has same problem and the popup window is ugly.. image

Hi, I think we can commit issues to coc plugins repo

fannheyward commented 2 years ago

@zoumi coc-clangd will add configuration to disable the progress notifications.

chemzqm commented 2 years ago

clangd has same problem and the popup window is ugly.. image

Fix the font in your terminal or configure notification

chemzqm commented 2 years ago

@zoumi coc-clangd will add configuration to disable the progress notifications.

Don't think that's necessary, it could be configured or use autocmd to close it just after create. The realy problem is they don't like automatic notification

Seb-C commented 2 years ago

What is the proper way to disable this popup permanently and for all languages? This started to appear since I've updated coc.vim and the extensions, and I find it highly bothersome.

I've tried many ways and syntaxes for "progressOnInitialization": false in my configuration file, but it's now seemingly enabled by default for all languages. It now appears for both golang and typescript.

chemzqm commented 2 years ago

but it's now seemingly enabled by default for all languages.

It's not, progressOnInitialization is disabled by default.

Seb-C commented 2 years ago

@chemzqm

It's not, progressOnInitialization is disabled by default.

I'm on the latest release branch and the feature is enabled without any specific configuration.

Maybe the changes needs to be released?

chemzqm commented 2 years ago

It's already used by latest release branch, possible enabled by extension. You can check the source of notification.

Seb-C commented 2 years ago

All my extensions started to behave this way after I updated coc.vim... I already checked in their documentation and source code, and there is no reference to this.

Seb-C commented 2 years ago

Just tried various other configuration syntaxes as well as forcefully setting the parameter to false in the source code of coc.vim, but nothing works to disable this.

I've reverted back my configuration to a random earlier commit (1d85f511f9966b445b5200f35f8db8d4cc0af805) for now, and I don't see it anymore.

untitaker commented 2 years ago

I don't understand why this is a per-plugin setting at all? Why can't I disable this globally?

chemzqm commented 2 years ago

Use "notification.disabledProgressSources": ["*"] in coc-settings.json to disable all progress notifications.

untitaker commented 2 years ago

much apprechiated, works exactly as expected!

narodnik commented 2 years ago

Who thought this was a good idea? Damn this is ugly. There goes an hour of my morning...

yaocccc commented 2 years ago

much apprechiated, works exactly as expected!

Seb-C commented 2 years ago

Thank you very much for reconsidering and implementing it. I will update my setup ASAP 🙂.

EDIT: Works well! Thank you.