search

neoclide / coc.nvim

Nodejs extension host for vim & neovim, load extensions like VSCode and host language servers.
Other
24.37k stars 956 forks source link

fix(model): fire onTextChange on TextChangedI #4875

Closed fannheyward closed 7 months ago

fannheyward commented 8 months ago

This fixes issue like https://github.com/neoclide/coc.nvim/issues/4873 on Vim, but https://github.com/neoclide/coc.nvim/blob/392264f475aea82419b493cec368b0bcf5ca40ee/src/model/document.ts#L648-L655 won't called anymore.

I've checked https://github.com/neoclide/coc.nvim/commit/930c6dc09c2c9db5d648d07033025d808283ec90, but still can't get the original logic, needs more tests.

Before this change, vim couldn't get correct lines of buffer as nvim.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.58%. Comparing base (00bd79e) to head (ac5516a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4875 +/- ## ======================================= Coverage 98.58% 98.58% ======================================= Files 273 273 Lines 26075 26075 Branches 5391 5391 ======================================= Hits 25705 25705 + Misses 217 216 -1 - Partials 153 154 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.