search

neoclide / coc.nvim

Nodejs extension host for vim & neovim, load extensions like VSCode and host language servers.
Other
24.37k stars 956 forks source link

fix(language-client): register DiagnosticRefreshRequest #4928

Closed fannheyward closed 7 months ago

fannheyward commented 7 months ago

https://github.com/yaegassy/coc-volar/pull/327

  1. LSP 3.16 and before, only push mode, server publishDiagnostics
  2. LSP 3.17 added refreshSupport, server will ask client to refresh from workspace/diagnostic/refresh
  3. LSP 3.17 also added pull mode, server provides diagnosticProvider, client pull diagnostics onSave/onChange etc

coc.nvim enabled refreshSupport but didn't onRequest DiagnosticRefreshRequest, could't handle workspace/diagnostic/refresh. Because no diagnosticProvider, coc.nvim cancelled registration.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.55%. Comparing base (96d43df) to head (344000d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4928 +/- ## ========================================== - Coverage 98.57% 98.55% -0.02% ========================================== Files 273 273 Lines 26077 26077 Branches 5392 5392 ========================================== - Hits 25706 25701 -5 - Misses 218 221 +3 - Partials 153 155 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.